src: replace var for let / const. #18649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace var for let or const.
nodejs-github-bot
added
async_hooks
BridgeAR
approved these changes
Feb 8, 2018
|
Light-CI (that is enough to test this change) https://ci.nodejs.org/job/node-test-commit-light/237/ |
julianduque
approved these changes
Feb 8, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Feb 9, 2018
|
Landed in df2f4ad 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
Replace var for let or const. PR-URL: nodejs#18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 10, 2018
Replace var for let or const. PR-URL: nodejs#18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Replace var for let or const. PR-URL: #18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Replace var for let or const. PR-URL: #18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Replace var for let or const. PR-URL: #18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Replace var for let or const. PR-URL: #18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Apr 13, 2018
Replace var for let or const. PR-URL: #18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Replace var for let or const. PR-URL: nodejs#18649 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Julian Duque <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
varforletorconstdepending on the case.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks, bootstrap_node, readline