doc: Add doc for performance.clearGC() #18331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
doc/api/perf_hooks.md
Outdated
| Remove all performance entry objects with `entryType` equal to `name` from the | ||
| Performance Timeline. | ||
|
|
||
| ### performance.clearGC() |
There was a problem hiding this comment.
Sorry for the nit, it seems this should go after performance.clearFunctions() ABC-wise)
There was a problem hiding this comment.
Thanks for the suggestion, I moved it below performance.clearFunctions().
jasnell
approved these changes
Jan 24, 2018
cjihrig
approved these changes
Jan 24, 2018
vsemozhetbyt
added
the
fast-track
XadillaX
approved these changes
Jan 24, 2018
gireeshpunathil
approved these changes
Jan 24, 2018
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jan 24, 2018
PR-URL: #18331 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18331 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18331 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18331 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance.clearGCseems to have been available since the original implementation ofperf_hooksbut it was missing from the docs. This PR adds documentation for it.Open to wording changes if something could be improved.
Checklist
Affected core subsystem(s)
doc