doc: add descriptions of state properties #18044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Jan 8, 2018
vsemozhetbyt
reviewed
Jan 8, 2018
doc/api/http2.md
Outdated
| * `lastProcStreamID` {number} The numeric id of the `Http2Stream` | ||
| for which a `HEADERS` or `DATA` frame was most recently received. | ||
| * `remoteWindowSize` {number} The number of bytes that this `Http2Session` | ||
| may sent without receiving a `WINDOW_UPDATE`. |
There was a problem hiding this comment.
Fixed! btw, @vsemozhetbyt ... I haven't said this enough, I really appreciate that you review the doc changes so closely and catch these typos. I tend to completely overlook them so I'm very happy to have someone paying such close attention to them.
There was a problem hiding this comment.
Thank you) I was often embarrassed to make only these petty comments about the nits while you folks did all the heavy lifting and all the great changes) I am glad this was not so annoying as a thought)
lpinca
approved these changes
Jan 9, 2018
jasnell
added a commit
that referenced
this pull request
Jan 10, 2018
Fixes: #15268 PR-URL: #18044 Fixes: #15268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 800caac |
evanlucas
pushed a commit
that referenced
this pull request
Jan 22, 2018
Fixes: #15268 PR-URL: #18044 Fixes: #15268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Fixes: #15268 PR-URL: #18044 Fixes: #15268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Fixes: #15268 PR-URL: #18044 Fixes: #15268 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15268
Checklist
Affected core subsystem(s)
doc, http2