test: fix flaky test-benchmark-fs #17853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call.
Trott
added
fast-track
2 tasks
|
|
maclover7
approved these changes
Dec 24, 2017
richardlau
approved these changes
Dec 24, 2017
|
Landed in c08f0d1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 25, 2017
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: nodejs#17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: #17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: #17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: #17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: #17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by calling common.refreshTmpDir(). Add that function call. PR-URL: #17853 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test