Skip to content

Conversation

MylesBorins
Copy link
Contributor

The PR number included for this api addition was originally incorrect.

Refs: #14903

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Dec 12, 2017
The PR number included for this api addition was originally incorrect.

Refs: nodejs#14903
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 12, 2017
@maclover7
Copy link
Contributor

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 12, 2017
The PR number included for this api addition was originally incorrect.

PR-URL: nodejs#17630
Refs: nodejs#14903
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
Copy link
Member

Landed in dc92540

BTW: I fixed the subsystem to "doc" 😉

@BridgeAR BridgeAR closed this Dec 12, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
MylesBorins added a commit that referenced this pull request Jan 10, 2018
The PR number included for this api addition was originally incorrect.

PR-URL: #17630
Refs: #14903
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
MylesBorins added a commit that referenced this pull request Jan 10, 2018
The PR number included for this api addition was originally incorrect.

PR-URL: #17630
Refs: #14903
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. https Issues or PRs related to the https subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants