[v6.x backport] src: remove unused includes from node_wrap.h #17092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot find any usages of these includes and think they can be removed. PR-URL: nodejs#16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
added
c++
gireeshpunathil
approved these changes
Nov 17, 2017
maclover7
approved these changes
Nov 24, 2017
|
Looks like CI failed, running one more time for posterity |
|
Landed in e67a377 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
I cannot find any usages of these includes and think they can be removed. Backport-PR-URL: #17092 PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
I cannot find any usages of these includes and think they can be removed. Backport-PR-URL: #17092 PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find any usages of these includes and think they can be
removed.
Refs: #16179
PR-URL: #16179
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: James M Snell [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src