src: fix SetClientCertEngine() nullptr dereference #16965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
4 tasks
fhinkel
approved these changes
Nov 12, 2017
4 tasks
cjihrig
approved these changes
Nov 12, 2017
jasnell
approved these changes
Nov 12, 2017
Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged November 11. PR-URL: nodejs#16965 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
fix-nullptr-deref
branch
from
d2bf0b1 to
6c76140
Compare
|
Landed in 6c76140. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged November 11. PR-URL: #16965 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
|
Depends on #14903, which is semver-minor |
|
Can only be backported if #14903 is backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in commit 6ee985f ("tls: implement clientCertEngine
option") which was merged yesterday.
CI: https://ci.nodejs.org/job/node-test-pull-request/11376/