Skip to content

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Nov 7, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

PR-URL: #16863

@hashseed hashseed requested a review from Trott November 7, 2017 14:16
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2017
@hashseed
Copy link
Member Author

hashseed commented Nov 7, 2017

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

hashseed added a commit that referenced this pull request Nov 7, 2017
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@hashseed
Copy link
Member Author

hashseed commented Nov 7, 2017

Landed in 3d7f0fe

@hashseed hashseed closed this Nov 7, 2017
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 11, 2017
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@hashseed hashseed deleted the hashseed-doc branch January 11, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants