test: refactor fs.write() test #16827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Nov 6, 2017
test/parallel/test-fs-write.js
Outdated
| })); | ||
| }); | ||
|
|
||
| fs.write(fd, '', 0, 'utf8', function(err, written) { |
There was a problem hiding this comment.
There probably needs to be a common.mustCall() for this callback as well.
There was a problem hiding this comment.
Like this:
const written = common.mustCall(function(err, written) {
assert.strictEqual(0, written);
});
fs.write(fd, '', 0, 'utf8', written);
?
There was a problem hiding this comment.
Either inline or not, doesn't really matter.
mscdex
reviewed
Nov 6, 2017
test/parallel/test-fs-write.js
Outdated
| assert.strictEqual(expected, found); | ||
| }); | ||
|
|
||
| fs.write(fd, '', 0, 'utf8', (err, written) => { |
mcollina
added
the
code-and-learn
|
AIX failure is unrelated (and now fixed if you want to do a re-run but I don't think that's necessary). |
jasnell
approved these changes
Nov 8, 2017
gireeshpunathil
approved these changes
Nov 13, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 8215c67 , thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16827 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Nov 18, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored fs.write() tests to use
done, thanks for your help @mcollina.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes