Skip to content

test: show incorrect value on test failure #16818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: show incorrect value on test failure #16818

wants to merge 1 commit into from

Conversation

seankarson
Copy link

@seankarson seankarson commented Nov 6, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11244/

@Trott
Copy link
Member

Trott commented Nov 7, 2017

CI was behaving strangely. Let's try again.

CI: https://ci.nodejs.org/job/node-test-pull-request/11251/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
@Trott
test: show incorrect value on test failure
09c152e 
PR-URL: nodejs#16818
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 09c152e.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@cjihrig
test: show incorrect value on test failure
a85d6e9 
PR-URL: nodejs#16818
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
test: show incorrect value on test failure
0ebded4 
PR-URL: #16818
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@XadillaX XadillaX XadillaX approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@seankarson @Trott @cjihrig @XadillaX @gireeshpunathil @MylesBorins @nodejs-github-bot