build: make lint-md-build quiet #16508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the lint-md-build target produces the following output: $ make lint-md-build if [ ! -d tools/remark-cli/node_modules ]; then \ cd tools/remark-cli && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \ cd tools/remark-preset-lint-node && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi This commit suppresses the echoing.
nodejs-github-bot
added
the
build
bengl
approved these changes
Oct 26, 2017
cjihrig
approved these changes
Oct 26, 2017
jasnell
approved these changes
Oct 26, 2017
lpinca
approved these changes
Oct 26, 2017
1 task
|
@danbev see #16551 (comment), I'd rather that code land, but that should really have been a review here. |
gibfahn
reviewed
Oct 27, 2017
| if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \ | ||
| cd tools/remark-preset-lint-node && ../../$(NODE) ../../$(NPM) install; fi | ||
| @if [ ! -d tools/remark-cli/node_modules ]; then \ | ||
| @cd tools/remark-cli && ../../$(NODE) ../../$(NPM) install; fi |
There was a problem hiding this comment.
I'd rather not have the @ on this line.
Also an echo to tell people why npm modules are randomly being installed would be useful (see #16551)
|
Closing in favour of #16551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lint-md-build target produces the following output:
This commit suppresses the echoing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build