Skip to content

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 29, 2017

Backport of #15578

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

errors,tools

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. tools Issues and PRs related to the tools directory. v8.x labels Sep 29, 2017
@refack refack requested a review from MylesBorins September 29, 2017 21:14
@refack
Copy link
Contributor Author

refack commented Sep 29, 2017

CI on both linter machines (one has LC_ALL=en_US and one has LC_ALL=C)
https://ci.nodejs.org/job/node-test-linter/12132/ ✔️
https://ci.nodejs.org/job/node-test-linter/12133/ ✔️

@MylesBorins
Copy link
Contributor

@refack could you do a rebase?

@refack refack force-pushed the backport-15578-to-v8.x branch from 106ab13 to 0e84007 Compare October 3, 2017 19:59
@refack
Copy link
Contributor Author

refack commented Oct 3, 2017

@MylesBorins
Copy link
Contributor

MylesBorins commented Oct 3, 2017

landed in 7a74504

@MylesBorins MylesBorins closed this Oct 3, 2017
@refack refack deleted the backport-15578-to-v8.x branch October 24, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants