Revert "inspector: rewrite inspector test helper" #14777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2296b67. That commit was landed without a green CI and is failing on Windows. Ref: nodejs#14460
nodejs-github-bot
added
dont-land-on-v4.x
inspector
3 tasks
refack
approved these changes
Aug 11, 2017
|
CI is back to green, landed in a6973a3 |
addaleax
added a commit
that referenced
this pull request
Aug 11, 2017
This reverts commit 2296b67. That commit was landed without a green CI and is failing on Windows. Ref: #14460 PR-URL: #14777 Reviewed-By: Refael Ackermann <[email protected]>
|
Windows CI was green: https://ci.nodejs.org/job/node-test-pull-request/9603/ There was a failure in OS X that was not relevant to that PR. |
|
Ooops, looks like at some point I messed up CI id, probably during the copy/paste! The CI seems to be for a wrong commit. I am really sorry. |
|
@eugeneo Yeah, no problem, just open a new PR with the changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2296b67.
That commit was landed without a green CI and is failing on Windows.
Ref: #14460
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test