Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 1, 2017

Backport of #14315 to 8.x-staging

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

* Add common/countdown utility
* Numerous improvements to http tests

PR-URL: nodejs#14315
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Aug 1, 2017
@jasnell jasnell requested a review from addaleax August 1, 2017 22:55
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

addaleax pushed a commit that referenced this pull request Aug 1, 2017
* Add common/countdown utility
* Numerous improvements to http tests

Backport-PR-URL: #14583
Backport-Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #14315
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@addaleax
Copy link
Member

addaleax commented Aug 1, 2017

Landed in b1fef05

@addaleax addaleax closed this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants