src: replace ASSERT with CHECK #14474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds always have asserts enabled so there is no point distinguishing between debug-only checks and run-time checks. Replace calls to ASSERT and friends with their CHECK counterparts. Fixes: nodejs#14461
nodejs-github-bot
added
c++
targos
approved these changes
Jul 25, 2017
seishun
approved these changes
Jul 25, 2017
jasnell
approved these changes
Jul 25, 2017
|
The comments still methon assertions in many places just above calls to The remaining usages of
@bnoordhuis Are those all intentional? |
XadillaX
approved these changes
Jul 26, 2017
cjihrig
approved these changes
Jul 26, 2017
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 27, 2017
Builds always have asserts enabled so there is no point distinguishing between debug-only checks and run-time checks. Replace calls to ASSERT and friends with their CHECK counterparts. Fixes: nodejs#14461 PR-URL: nodejs#14474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: XadillaX <[email protected]>
|
@ChALkeR node.h and node_object_wrap.h are public headers, they can't use CHECK. I'll open a separate PR for the other two. (I pointed out the assert() in node_api.cc a while ago but seems it hasn't been fixed yet.) edit: wups, the PR I put up for review didn't contain the change to node.gyp. |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
Builds always have asserts enabled so there is no point distinguishing between debug-only checks and run-time checks. Replace calls to ASSERT and friends with their CHECK counterparts. Fixes: #14461 PR-URL: #14474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: XadillaX <[email protected]>
Merged
|
Should this be backported to |
|
ping @bnoordhuis |
1 similar comment
|
ping @bnoordhuis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds always have asserts enabled so there is no point distinguishing
between debug-only checks and run-time checks. Replace calls to ASSERT
and friends with their CHECK counterparts.
Fixes: #14461
CI: https://ci.nodejs.org/job/node-test-pull-request/9343/