Skip to content

replacc string concatenation in test/parallel/test-https-unix-socket-… #14282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

replacc string concatenation in test/parallel/test-https-unix-socket-… #14282

wants to merge 1 commit into from

Conversation

zyziyun
Copy link

@zyziyun zyziyun commented Jul 16, 2017

…self-signed.js with template literals

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@TimothyGu TimothyGu added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Jul 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9150/

@tniessen tniessen self-assigned this Jul 16, 2017
Trott
Trott reviewed Jul 16, 2017
View reviewed changes
test/parallel/test-https-unix-socket-self-signed.js
const options = {
cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem'),
key: fs.readFileSync(common.fixturesDir + '/test_key.pem')
cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyziyun Would you consider altering these to use path.join() instead? For example:

  cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'),

@Trott
Copy link
Member

Trott commented Jul 26, 2017

This change already landed in #14286. Closing. Thanks!

@Trott Trott closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tniessen tniessen

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zyziyun @Trott @cjihrig @tniessen @gibfahn @TimothyGu @nodejs-github-bot