Skip to content

doc: add tls.parseCertString() #14196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

doc: add tls.parseCertString() #14196

wants to merge 2 commits into from

Conversation

@XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Jul 12, 2017 •
edited
Loading

Refs: #14193

Checklist
Affected core subsystem(s)

doc, tls

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jul 12, 2017
refack
refack approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

doc/api/tls.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

`str` {string} A Cert in [`ini`][] format.

[`ini`]: https://en.wikipedia.org/wiki/INI_file

doc/api/tls.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Returns the parsed object.

For example:

doc/api/tls.md Outdated
Copy link
Contributor

@refack refack Jul 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

will return —

@cjihrig
Copy link
Contributor

cjihrig commented Jul 12, 2017

See @bnoordhuis comment: #14193 (comment)

@refack refack added the blocked PRs that are blocked by other issues or PRs. label Jul 12, 2017
@refack
Copy link
Contributor

refack commented Jul 12, 2017

Blocked till deprecation is decided

@XadillaX XadillaX changed the base branch from master to v8.x-staging July 13, 2017 07:19
@XadillaX XadillaX force-pushed the doc/tls.parseCertString branch from d0b39da to d61d561 Compare July 13, 2017 07:42
refack
refack approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
awaiting deprecation decision

@XadillaX XadillaX mentioned this pull request Jul 13, 2017
Closed
3 tasks
@XadillaX
Copy link
Contributor Author

@refack I've created another PR to move the function. #14218

@cjihrig
Copy link
Contributor

cjihrig commented Jul 13, 2017

@XadillaX can this PR be closed?

@XadillaX
Copy link
Contributor Author

@cjihrig sure

@cjihrig cjihrig closed this Jul 13, 2017
@refack
Copy link
Contributor

refack commented Jul 13, 2017

Superseded by #14218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XadillaX @cjihrig @refack @lpinca @nodejs-github-bot