Skip to content

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 27, 2017

Refs: #13924

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Jun 27, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 30, 2017

Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <[email protected]>
@cjihrig cjihrig merged commit f803e77 into nodejs:master Jun 30, 2017
@cjihrig cjihrig deleted the del-element branch June 30, 2017 21:11
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
@addaleax addaleax mentioned this pull request Jul 3, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Refs: #13924
Backport-PR-URL: #19447
PR-URL: #13949
Reviewed-By: Jason Ginchereau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants