Skip to content

test: delete outdated fixtures/stdio-filter.js #13712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: delete outdated fixtures/stdio-filter.js #13712

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

I cannot find where this file is used. Please, correct me if I miss something.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 16, 2017
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8685/

Trott
Trott approved these changes Jun 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

cjihrig
cjihrig approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green

@mscdex
Copy link
Contributor

mscdex commented Jun 16, 2017

LGTM

@vsemozhetbyt
Copy link
Contributor Author

Landed in aaa80df

@vsemozhetbyt vsemozhetbyt deleted the x-test-stdio-filter branch June 18, 2017 23:31
vsemozhetbyt added a commit that referenced this pull request Jun 18, 2017
@vsemozhetbyt
test: delete outdated fixtures/stdio-filter.js
aaa80df 
PR-URL: #13712
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
@vsemozhetbyt @addaleax
test: delete outdated fixtures/stdio-filter.js
fab0072 
PR-URL: #13712
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@vsemozhetbyt @addaleax
test: delete outdated fixtures/stdio-filter.js
d0f39cc 
PR-URL: #13712
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Brian White <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+2 more reviewers

@aqrln aqrln aqrln approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@vsemozhetbyt @mscdex @jasnell @Trott @lpinca @cjihrig @aqrln @gibfahn @MylesBorins @nodejs-github-bot