Skip to content

lib: return this from net.Socket.end() #13481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam-github merged 1 commit into from
Jun 7, 2017
Merged

lib: return this from net.Socket.end() #13481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/api/net.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,8 @@ server will still send some data.
If `data` is specified, it is equivalent to calling
`socket.write(data, encoding)` followed by [`socket.end()`][].

Returns `socket`.

### socket.localAddress
<!-- YAML
added: v0.9.6
Expand Down
2 changes: 2 additions & 0 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,8 @@ Socket.prototype.end = function(data, encoding) {
this.read(0);
else
maybeDestroy(this);

return this;
};


Expand Down
5 changes: 3 additions & 2 deletions test/parallel/test-socket-write-after-fin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
const assert = require('assert');
const net = require('net');
const expected = 'hello1hello2hello3\nTHUNDERMUSCLE!';
const expected = 'hello1hello2hello3\nbye';

const server = net.createServer({
allowHalfOpen: true
Expand Down Expand Up @@ -35,5 +35,6 @@ server.listen(0, common.mustCall(function() {
sock.write('hello1');
sock.write('hello2');
sock.write('hello3\n');
sock.end('THUNDERMUSCLE!');
assert.strictEqual(sock.end('bye'), sock);

}));