Skip to content

doc: fix code examples in url.md #13268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

doc: fix code examples in url.md #13268

wants to merge 3 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, url

  • update outputs in code examples
  • refine spaces in code examples
  • restore missing part in code example (unify with other examples)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels May 28, 2017
@vsemozhetbyt vsemozhetbyt changed the title doc: modernize and fix code examples in url.md doc: fix code examples in url.md May 28, 2017
@vsemozhetbyt
Copy link
Contributor Author

Linter CI: https://ci.nodejs.org/job/node-test-linter/9420/

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 29, 2017 •
edited
Loading

It seems after the #12710 landed url.md is too different doc to just resolve the conflicts. I shall close this PR and shall start a new PR later.

@vsemozhetbyt vsemozhetbyt deleted the url.md branch May 29, 2017 17:11
@vsemozhetbyt vsemozhetbyt mentioned this pull request May 29, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt @refack @cjihrig @nodejs-github-bot