test: improve N-API test coverage #13006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests top cover functions that returns globals
nodejs-github-bot
added
node-api
cjihrig
approved these changes
May 12, 2017
addaleax
approved these changes
May 12, 2017
jasongin
approved these changes
May 13, 2017
|
CI good, landing. |
|
Landed as 47c3c58 |
mhdawson
added a commit
that referenced
this pull request
May 16, 2017
Add tests to cover functions that return globals PR-URL: #13006 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Add tests to cover functions that return globals PR-URL: nodejs#13006 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Add tests to cover functions that return globals PR-URL: nodejs#13006 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Add tests to cover functions that return globals Backport-PR-URL: #19447 PR-URL: #13006 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests top cover functions that returns globals
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api