build: support dtrace on ARM #12193
Closed
build: support dtrace on ARM #12193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081
nodejs-github-bot
added
the
build
bnoordhuis
approved these changes
Apr 3, 2017
cjihrig
approved these changes
Apr 4, 2017
jasnell
approved these changes
Apr 4, 2017
|
Landed in f84666f. |
lpinca
pushed a commit
that referenced
this pull request
May 27, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: #12193 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: #12193 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
|
Should this be enabled for v6.x? |
|
Hi, sorry for the late response (vacation). Ideally, yes, this should be in 6.x as well. |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 14, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: #12193 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: #12193 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build