util: cleanup internalUtil.deprecate #11450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
targos
approved these changes
Feb 18, 2017
cjihrig
approved these changes
Feb 18, 2017
lpinca
approved these changes
Feb 19, 2017
|
CI results were a bit weird, trying again: https://ci.nodejs.org/job/node-test-pull-request/6500/ |
There were two functions `deprecate` and `_deprecate` that were really just aliases of each other. Simplify
jasnell
force-pushed
the
internal-deprecate-cleanup
branch
from
51e9257 to
1b565ca
Compare
jasnell
added a commit
that referenced
this pull request
Feb 19, 2017
There were two functions `deprecate` and `_deprecate` that were really just aliases of each other. Simplify PR-URL: #11450 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 0510472 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 25, 2017
There were two functions `deprecate` and `_deprecate` that were really just aliases of each other. Simplify PR-URL: nodejs#11450 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
note to self... this will need a backport PR for 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two functions
deprecateand_deprecatethat were really just aliases of each other. SimplifyChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
internal util