Skip to content

test: improve events coverage to check removeListeners functions #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: improve events coverage to check removeListeners functions #11140

wants to merge 1 commit into from

Conversation

cauchym
Copy link

@cauchym cauchym commented Feb 3, 2017

I improved test coverage for events. I found removeListerers , removeAllListerers tests. However remove(All)Listener(s) function does not pass some points. This PR will improve coverage.

I found this commit, but it seems to need to add tests when _events is undefined.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2017
@hiroppy hiroppy added the events Issues and PRs related to the events subsystem / EventEmitter. label Feb 3, 2017
@italoacasas
Copy link

CI: https://ci.nodejs.org/job/node-test-pull-request/6194/console

mhdawson
mhdawson approved these changes Feb 3, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Feb 3, 2017
@jasnell
test: improve coverage on removeListeners functions
7d2dc90 
PR-URL: #11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 3, 2017

Landed in 7d2dc90

@jasnell jasnell closed this Feb 3, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 4, 2017
test: improve coverage on removeListeners functions
cc7408a 
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@italoacasas italoacasas mentioned this pull request Feb 5, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
test: improve coverage on removeListeners functions
e9f6bc6 
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@krydos
test: improve coverage on removeListeners functions
9e6230f 
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@jasnell
test: improve coverage on removeListeners functions
039f3f4 
PR-URL: #11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@jasnell
test: improve coverage on removeListeners functions
0907684 
PR-URL: #11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@MylesBorins
test: improve coverage on removeListeners functions
c161604 
PR-URL: #11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@MylesBorins
test: improve coverage on removeListeners functions
1db89d4 
PR-URL: #11140
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cauchym @italoacasas @jasnell @cjihrig @mhdawson @hiroppy @nodejs-github-bot