test: guarantee test runs in test-readline-keys #11023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common.mustCall() to guarantee that test functions (created by a factory function) are run.
Trott
added
readline
cjihrig
approved these changes
Jan 26, 2017
hiroppy
approved these changes
Jan 26, 2017
Fishrock123
approved these changes
Jan 27, 2017
jasnell
approved these changes
Jan 27, 2017
|
Only failure in CI is an unrelated and known flaky: #11041 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 29, 2017
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: nodejs#11023 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 87b4486 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 31, 2017
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: #11023 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: #11023 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
landed on v6, needs a backport PR if it should land on v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: #11023 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common.mustCall() to guarantee that test functions (created by a
factory function) are run.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test readline