Skip to content

src: add NODE_NO_WARNINGS to --help output #10918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2017
Merged

src: add NODE_NO_WARNINGS to --help output #10918

merged 1 commit into from
Jan 23, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 20, 2017 •
edited
Loading

This commit adds a description of the NODE_NO_WARNINGS environment variable to the --help output. This was overlooked in 4990212.

Refs: #10842

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

CI: https://ci.nodejs.org/job/node-test-pull-request/5997/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v7.x labels Jan 20, 2017
@cjihrig cjihrig mentioned this pull request Jan 20, 2017
Merged
4 tasks
@cjihrig
src: add NODE_NO_WARNINGS to --help output
f69e59d 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 23, 2017

The CI failure seems infrastructure related, and this is a trivial change. Landing.

@cjihrig cjihrig merged commit f69e59d into nodejs:master Jan 23, 2017
@cjihrig cjihrig deleted the help branch January 23, 2017 16:39
targos pushed a commit that referenced this pull request Jan 28, 2017
@cjihrig @targos
src: add NODE_NO_WARNINGS to --help output
e08ddac 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig
src: add NODE_NO_WARNINGS to --help output
cd94642 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig
src: add NODE_NO_WARNINGS to --help output
3057c55 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: nodejs#10842
PR-URL: nodejs#10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@cjihrig @jasnell
src: add NODE_NO_WARNINGS to --help output
23fc1ef 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
src: add NODE_NO_WARNINGS to --help output
b5a0d46 
This commit adds a description of the NODE_NO_WARNINGS
environment variable to the --help output. This was overlooked
in 4990212.

Refs: #10842
PR-URL: #10918
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

+3 more reviewers

@sam-github sam-github sam-github approved these changes

@silverwind silverwind silverwind approved these changes

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cjihrig @sam-github @silverwind @targos @italoacasas @mscdex @jasnell @MylesBorins @nodejs-github-bot