test: increase coverage of string-decoder #10863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
Trott
reviewed
Jan 18, 2017
There was a problem hiding this comment.
Optional: This could just be (b) => Buffer.from(b). (The current code base does have a mixture of using {...} and return when it's not required vs. omitting them, so either should be fine, but omitting them is definitely more common.)
Trott
reviewed
Jan 18, 2017
There was a problem hiding this comment.
Similarly, this arrow function could be (_, j) => j + 0x78 if you like.
|
s/starting/string/ in commit message |
hiroppy
force-pushed
the
feature/increase-coverage-of-string-decoder
branch
from
46a0454 to
7d5c020
Compare
mscdex
added
string_decoder
hiroppy
force-pushed
the
feature/increase-coverage-of-string-decoder
branch
from
7d5c020 to
075cb4b
Compare
hiroppy
changed the title
|
Oops... updated. Thanks :) |
jasnell
approved these changes
Jan 18, 2017
lpinca
reviewed
Jan 18, 2017
test/parallel/test-string-decoder.js
Outdated
There was a problem hiding this comment.
Nit: does the linter complain if the assignment is removed?
There was a problem hiding this comment.
Nope. I deleted the assignment.
lpinca
approved these changes
Jan 18, 2017
cjihrig
approved these changes
Jan 18, 2017
hiroppy
force-pushed
the
feature/increase-coverage-of-string-decoder
branch
from
075cb4b to
bed8892
Compare
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9
hiroppy
force-pushed
the
feature/increase-coverage-of-string-decoder
branch
from
bed8892 to
dfebdc6
Compare
addaleax
approved these changes
Jan 21, 2017
|
Landed in aebcc1a0d95b5f9e138da3c185c0ba25e5cd0fef |
|
@addaleax commit title seems a bit off: "starting-decoder"? |
|
@lpinca thanks for catching, force-pushed to fix 😅 |
addaleax
pushed a commit
that referenced
this pull request
Jan 21, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: nodejs#10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: nodejs#10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in v6. This will need a backport PR if it needs to land on v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Make use of Arrow Function. Add normalizeencoding's test. normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9 PR-URL: #10863 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add normalizeencoding's test.
normalizeEncoding: https://github.com/nodejs/node/blob/master/lib/string_decoder.js#L9
Make use of Arrow Function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test