Skip to content

test: improve code in test-http-host-headers #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: improve code in test-http-host-headers #10830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 12 additions & 25 deletions test/parallel/test-http-host-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
'use strict';
require('../common');
const common = require('../common');
const http = require('http');
const assert = require('assert');
const httpServer = http.createServer(reqHandler);

function reqHandler(req, res) {
console.log('Got request: ' + req.headers.host + ' ' + req.url);
if (req.url === '/setHostFalse5') {
assert.strictEqual(req.headers.host, undefined);
} else {
Expand All @@ -14,14 +13,9 @@ function reqHandler(req, res) {
req.headers.host);
}
res.writeHead(200, {});
//process.nextTick(function() { res.end('ok'); });
res.end('ok');
}

function thrower(er) {
throw er;
}

testHttp();

function testHttp() {
Expand All @@ -30,59 +24,52 @@ function testHttp() {

function cb(res) {
counter--;
console.log('back from http request. counter = ' + counter);
if (counter === 0) {
httpServer.close();
}
res.resume();
}

httpServer.listen(0, function(er) {
console.error(`test http server listening on ${this.address().port}`);
httpServer.listen(0, (er) => {
assert.ifError(er);
http.get({
method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
port: this.address().port,
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower);
}, cb).on('error', common.fail);

http.request({
method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
port: this.address().port,
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();
}, cb).on('error', common.fail).end();

http.request({
method: 'POST',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
port: this.address().port,
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();
}, cb).on('error', common.fail).end();

http.request({
method: 'PUT',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
port: this.address().port,
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();
}, cb).on('error', common.fail).end();

http.request({
method: 'DELETE',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
port: this.address().port,
port: httpServer.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();
}, cb).on('error', common.fail).end();
});
}