Skip to content

test: fix and improve debugger-client test #10371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix and improve debugger-client test #10371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions test/debugger/test-debugger-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ setTimeout(function() {

let resCount = 0;
const p = new debug.Protocol();
p.onResponse = function(res) {
p.onResponse = function() {
resCount++;
};

Expand Down Expand Up @@ -89,7 +89,7 @@ function addTest(cb) {
addTest(function(client, done) {
console.error('requesting version');
client.reqVersion(function(err, v) {
assert.ok(!err);
assert.ifError(err);
console.log('version: %s', v);
assert.strictEqual(process.versions.v8, v);
done();
Expand All @@ -99,13 +99,13 @@ addTest(function(client, done) {
addTest(function(client, done) {
console.error('requesting scripts');
client.reqScripts(function(err) {
assert.ok(!err);
assert.ifError(err);
console.error('got %d scripts', Object.keys(client.scripts).length);

let foundMainScript = false;
for (const k in client.scripts) {
const script = client.scripts[k];
if (script && script.name === 'node.js') {
if (script && script.name === 'bootstrap_node.js') {
foundMainScript = true;
break;
}
Expand All @@ -119,7 +119,7 @@ addTest(function(client, done) {
console.error('eval 2+2');
client.reqEval('2+2', function(err, res) {
console.error(res);
assert.ok(!err);
assert.ifError(err);
assert.strictEqual(res.text, '4');
assert.strictEqual(res.value, 4);
done();
Expand All @@ -137,7 +137,7 @@ function doTest(cb, done) {
const args = ['--debug=' + debugPort, '-e', script];
nodeProcess = spawn(process.execPath, args);

nodeProcess.stdout.once('data', function(c) {
nodeProcess.stdout.once('data', function() {
console.log('>>> new node process: %d', nodeProcess.pid);
let failed = true;
try {
Expand All @@ -158,7 +158,7 @@ function doTest(cb, done) {
console.error('got stderr data %j', data);
nodeProcess.stderr.resume();
b += data;
if (didTryConnect === false && b.match(/Debugger listening on port/)) {
if (didTryConnect === false && b.match(/Debugger listening on /)) {
didTryConnect = true;

// The timeout is here to expose a race in the bootstrap process.
Expand All @@ -168,10 +168,10 @@ function doTest(cb, done) {

function tryConnect() {
// Wait for some data before trying to connect
var c = new debug.Client();
const c = new debug.Client();
console.error('>>> connecting...');
c.connect(debug.port);
c.on('break', function(brk) {
c.on('break', function() {
c.reqContinue(function() {});
});
c.on('ready', function() {
Expand Down Expand Up @@ -199,7 +199,7 @@ function doTest(cb, done) {


function run() {
var t = tests[0];
const t = tests[0];
if (!t) return;

doTest(t, function() {
Expand Down