invalid floating point uid or gid for spawn/execSync causes uv to assert and abort node

[sam-github]

• Version: 0.12 to v8.0.0-pre

> child_process.spawnSync("cat", {uid: 3.5})
node: ../deps/uv/src/unix/core.c:166: uv_close: Assertion `0' failed.
zsh: abort (core dumped)  ./node

Also

> child_process.execSync("date", {uid: 3.5})
node: ../deps/uv/src/unix/core.c:161: uv_close: Assertion `0' failed.
zsh: abort (core dumped)
% ./node --version
v8.0.0-pre

EDIT: git aborts, too

[sam-github]

See #8312 (comment), /to @saghul not sure if this is a uv bug, or node not checking for bad input before calling uv.

[cjihrig]

I'll take care of the validation in Node in #8312. It might be good for libuv to return EINVAL or something though.

[sam-github]

@cjihrig I assumed you would validate, I reported because #8321 is semver-major, and this bug exists all the way back to 0.12, so across every LTS release, so some sub-set of #8321 will need to be backported.

[sam-github]

@cjihrig did I do right to label it with the node versions it effects? Is that the trigger for the fix to be backported?

[cjihrig]

I think so, but I think backports are more driven by the labels on the PRs (lts-watch-*, dont-land-on-*).

It would great if what each label meant could be documented somewhere (preferably by GitHub). They are usually self explanatory, but we're up to 100 of them.