How does require.resolve work?

[ccorcos]

I'd like to submit a PR that resolves the root project's package name so that you can use absolute require paths. However, I'm finding it very hard to figured out how this bit of code works:

https://github.com/nodejs/node/blob/7b73f559029a10474b74a83bfb1117ab512785d4/lib/module.js

Seems like it should be a one-liner somewhere. I just need to add the base project as one of the "paths" to search. Any ideas where that might be?

I'm thinking its in here.

node/lib/module.js

Line 304 in 7b73f55

Module._resolveLookupPaths = function(request, parent) {

Something like paths.push(path.dirname(parent.id)).

[cjihrig]

Can you give an example, preferably in runnable code, that demonstrates exactly what you want to happen? Also, keep in mind that the chances of landing a PR that changes the module system behavior is extremely small.

[imyller]

Be careful when attempting to resolve paths/files in the parent path of current package.

For example, current package could be npm link symlinked to the project and when attempting to resolve root project's location you might wander into completely different root path or even filesystem inaccessible to current user.

All this assuming I understood correctly your intentions about "resolving the root project's package name".

As @cjihrig suggested, runnable code would demonstrate your intentions best.

[ccorcos]

@cjihrig Here's basically what I want to work:

mkdir cool-app
cd cool-app
npm init -y
echo "module.exports = { name: 'chet' }" > defs.js
echo "console.log('hello' + require('cool-app/defs').name)" > index.js
node index.js
> hello chet

basically cool-app resolves to the project root, just like it were an npm package dependency.

[imyller]

So you basicly want virtual version of:

ln -sf .. node_modules/<root package name>

Tested this and symlink actually works and allows require('<root package name>') aliasing.

If this is implemented in module.js resolver, I'm bit worried about (theoretically) possible name collision with npm installed packages.

[cjihrig]

I'm not sure that making this change is worth the risk, especially when you can already use relative paths. I'll leave this open in case another collaborator is willing to champion this.

[evanlucas]

-1 from me. The module system is locked.

[imyller]

-1 from me too.

Locked module API and high risk for hard-to-debug userland regressions if implemented.

[JacksonTian]

-1 from me.

[cjihrig]

I think there are enough -1s to warrant closing this. Thanks anyway though!