-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Closed
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.regressionIssues related to regressions.Issues related to regressions.
Description
Version
main
Platform
n/a
Subsystem
benchmark
What steps will reproduce the bug?
./out/Release/node benchmark/run.js --format csv -- assert
How often does it reproduce? Is there a required condition?
Every time
What is the expected behavior?
Output should be in CSV format
What do you see instead?
"Normal" formatted output
Additional information
While d636fee seems to have fixed the truncated results output, it introduced a regression with explicit output formatting (and possibly other settings).
We need to add more tests to cover more of the benchmark runner's features, including output type.
/cc @ShogunPanda
Metadata
Metadata
Assignees
Labels
benchmarkIssues and PRs related to the benchmark subsystem.Issues and PRs related to the benchmark subsystem.regressionIssues related to regressions.Issues related to regressions.