Skip to content

change test/addons/ to ignore empty folders #14843

@Fishrock123

Description

@Fishrock123
  • Version: all with /addons/ tests
  • Platform: at least macOS and Linux
  • Subsystem: test

When changing branches sometimes git seems to leave empty folders behind which in the case of the test/addons/ directory causes at least gyp to explode with an error similar to:

Building addon /Users/Jeremiah/Documents/node/test/addons/async-hooks-id/
gyp: binding.gyp not found (cwd: /Users/Jeremiah/Documents/node/test/addons/async-hooks-id) while trying to load binding.gyp
Makefile:192: recipe for target 'test/addons/.buildstamp' failed
make[1]: *** [test/addons/.buildstamp] Error 1
make[1]: Leaving directory '/Users/Jeremiah/Documents/node'
Makefile:133: recipe for target 'test' failed
make: *** [test] Error 2

Metadata

Metadata

Assignees

No one assigned

    Labels

    addonsIssues and PRs related to native addons.buildIssues and PRs related to build files or the CI.good first issueIssues that are suitable for first-time contributors.testIssues and PRs related to the tests.wipIssues and PRs that are still a work in progress.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions