Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Cleanup of 'NativeModule.require' calls in lib/module.js #2009

@ghost

Description

All calls to NativeModule.require called with string literal argument ('fs' and 'path') are unnecessarily explicitly referring to NativeModule and can and should be changed to plain require call. This matches with the way how any other native module perform these requires (module.js is in no way special in this).
Only call which should retain the explicit NativeModule.require is the one inside Module._load which calls with a variable argument id, not with a literal argument.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions