Skip to content

claims that PR is not accepted yet #8

@sam-github

Description

@sam-github

Oh, no! I don't think I can live without node-review anymore, and its not working for me with nodejs/node#5923

It claims

Error: This pull request is not yet ready to land. 
The following reviewers have requested changes: 

Yes, that is the empty list, because all reviewers have accepted the changes. Just me, or is it a problem for other people? I haven't landed any changes for almost 2 weeks (vacation, travel), so I don't know if this is new or not.

I wonder if its coincidental that I recently reported a bug to github where some reviewers listed in the conversation review summary at the bottom of the thread were not listed in the review area at the top-right of the page, a problem they fixed a week or so ago.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions