Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 21, 2019

@refack @thefourtheye Your reviews please.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Remove an outdated workaround for Python 2.4. This change will work on all currently supported versions of Python and will also work on Python 3.

bnoordhuis pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #1650
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM and landed in 83f8749.

@bnoordhuis bnoordhuis closed this Feb 12, 2019
rvagg pushed a commit that referenced this pull request Apr 24, 2019
PR-URL: #1650
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@rvagg rvagg mentioned this pull request Apr 24, 2019
@cclauss cclauss deleted the patch-1 branch June 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants