Skip to content

fix: switch to undici for requests to fix stream close errors #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2023
Merged

fix: switch to undici for requests to fix stream close errors #666

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8dd3ea
fix: switch to undici for requests to fix stream close errors
austinkelleher Feb 19, 2023
5b81893
chore: include Node.js 19.x in test strategy
austinkelleher Feb 19, 2023
a9c0974
chore: update node engines to >=16.8.0 for undici fetch support
austinkelleher Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x]
os: [ubuntu-latest, macOS-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import fs from 'node:fs';

import fetch from 'node-fetch';
import { fetch } from 'undici';

import { CI_DOMAIN } from './ci/ci_type_parser.js';
import proxy from './proxy.js';
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@
"listr2": "^4.0.5",
"lodash": "^4.17.21",
"log-symbols": "^5.1.0",
"node-fetch": "^3.2.4",
"ora": "^6.1.0",
"proxy-agent": "^5.0.0",
"replace-in-file": "^6.3.2",
"rimraf": "^3.0.2",
"undici": "^5.20.0",
"which": "^2.0.2",
"yargs": "^17.5.0"
},
Expand Down