Skip to content

Conversation

richardlau
Copy link
Member

Underscores in the links to the changelogs are escaped for markdown
links but not escaped for HTML links.

Refs: #573
Refs: nodejs/node#40617

Underscores in the links to the changelogs are escaped for markdown
links but not escaped for HTML links.
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #575 (0482bb8) into main (44c6fc8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c6fc8...0482bb8. Read the comment docs.

@richardlau

This comment has been minimized.

@Trott
Copy link
Member

Trott commented Oct 26, 2021

I'm contemplating seeing if remark-gfm can be changed so that it doesn't escape _ in these situations at all. It's unnecessary, I think.

@richardlau richardlau merged commit e66ba17 into nodejs:main Oct 26, 2021
@richardlau richardlau deleted the auto-lts branch October 26, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants