feat!: convert all modules running in loader thread to ESM #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
force-pushed
the
bengl/fix-double-loader-issue-again
branch
2 times, most recently
from
8bbd087 to
9d748c2
Compare
jsumners-nr
reviewed
Sep 25, 2025
jsumners-nr
previously approved these changes
Sep 26, 2025
bengl
changed the title
Member
Author
|
@timfish done ✅ |
Contributor
|
We should probably merge #211 before we cut a major! |
Contributor
|
@bengl unfortunately there are conflicts after that other PR! |
This is a second attempt at fixing the double-loader issue in nodejs#205. The tests from that commit are included.
bengl
force-pushed
the
bengl/fix-double-loader-issue-again
branch
from
a16088b to
1040ab4
Compare
timfish
approved these changes
Oct 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at fixing the double-loader issue in #205. The tests from that commit are included.