This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Ignore Upgrade header outside of 101 response. #364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
bassosimone
added a commit
to measurement-kit/measurement-kit
that referenced
this pull request
May 10, 2017
Fixes advertising possible protocol upgrade to, e.g., `http2` such as the case noticed with `http://www.aseansec.org`.
bassosimone
added a commit
to measurement-kit/measurement-kit
that referenced
this pull request
May 11, 2017
* Cherry pick nodejs/http-parser#364 Fixes advertising possible protocol upgrade to, e.g., `http2` such as the case noticed with `http://www.aseansec.org`. * Repair regress tests
bassosimone
added a commit
to measurement-kit/measurement-kit
that referenced
this pull request
May 12, 2017
Fixes advertising possible protocol upgrade to, e.g., `http2` such as the case noticed with `http://www.aseansec.org`.
Closed
indutny
pushed a commit
that referenced
this pull request
Jun 14, 2017
PR-URL: #364 Reviewed-By: Fedor Indutny <[email protected]>
indutny
pushed a commit
that referenced
this pull request
Jun 14, 2017
PR-URL: #364 Reviewed-By: Fedor Indutny <[email protected]>
Member
shekhei
pushed a commit
to shekhei/http-parser
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#364 Reviewed-By: Fedor Indutny <[email protected]>
shekhei
pushed a commit
to shekhei/http-parser
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#364 Reviewed-By: Fedor Indutny <[email protected]>
shekhei
pushed a commit
to shekhei/http-parser
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#364 Reviewed-By: Fedor Indutny <[email protected]>
shekhei
pushed a commit
to shekhei/http-parser
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#364 Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #363. Open question: could anyone be relying on the current behavior?