labels: add version labels

lib/node-labels.js

@@ -53,12 +53,27 @@ const exclusiveLabelsMap = new Map([
   [/^benchmark\//, 'benchmark']
 ])
 
-function resolveLabels (filepathsChanged, limitLib = true) {
+function resolveLabels (filepathsChanged, baseBranch, limitLib = true) {
   const exclusiveLabels = matchExclusiveSubSystem(filepathsChanged)
 
-  return (exclusiveLabels.length > 0)
-          ? exclusiveLabels
-          : matchAllSubSystem(filepathsChanged, limitLib)
+  if (typeof baseBranch !== 'string') {
+    if (typeof baseBranch === 'boolean') {
+      limitLib = baseBranch
+    }
+    baseBranch = ''
+  }
+
+  const labels = (exclusiveLabels.length > 0)
+                  ? exclusiveLabels
+                  : matchAllSubSystem(filepathsChanged, limitLib)
+
+  // Add version labels if PR is made against a version branch
+  const m = /^(v\d+\.(?:\d+|x))(?:-|$)/.exec(baseBranch)
+  if (m) {
+    labels.push(m[1])
+  }
+
+  return labels
 }
 
 function hasAllSubsystems (arr) {

lib/node-repo.js

@@ -15,7 +15,8 @@ function resolveLabelsThenUpdatePr (options) {
     }
 
     const filepathsChanged = res.map((fileMeta) => fileMeta.filename)
-    updatePrWithLabels(options, resolveLabels(filepathsChanged))
+    const labels = resolveLabels(filepathsChanged, options.baseBranch)
+    updatePrWithLabels(options, labels)
   })
 }
 

scripts/node-subsystem-label.js

@@ -10,6 +10,7 @@ module.exports = function (app) {
   function handlePrCreated (event, owner, repo) {
     const prId = event.number
     const logger = event.logger
+    const baseBranch = event.pull_request.base.ref
 
     // subsystem labelling is for node core only
     if (repo !== 'node') return
@@ -18,6 +19,12 @@ module.exports = function (app) {
     // by not hard coding the owner repo to nodejs/node here,
     // we can test these this script in a different repo than
     // *actual* node core as long as the repo is named "node"
-    nodeRepo.resolveLabelsThenUpdatePr({ owner, repo, prId, logger })
+    nodeRepo.resolveLabelsThenUpdatePr({
+      owner,
+      repo,
+      prId,
+      logger,
+      baseBranch
+    })
   }
 }

test/node-labels.test.js

@@ -241,3 +241,59 @@ tap.test('label: not "doc" when other top-level files have been changed', (t) =>
 
   t.end()
 })
+
+tap.test('label: version labels (old)', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'common.gypi'
+  ], 'v0.12')
+
+  t.same(labels, ['build', 'v0.12'])
+
+  t.end()
+})
+
+tap.test('label: version labels (old, staging)', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'common.gypi'
+  ], 'v0.12-staging')
+
+  t.same(labels, ['build', 'v0.12'])
+
+  t.end()
+})
+
+tap.test('label: version labels (new)', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'deps/v8/include/v8-version.h',
+    'deps/v8/src/crankshaft/hydrogen.cc',
+    'deps/v8/test/mjsunit/regress/regress-5033.js'
+  ], 'v6.x')
+
+  t.same(labels, ['v8', 'v6.x'])
+
+  t.end()
+})
+
+tap.test('label: version labels (new, staging)', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'deps/v8/include/v8-version.h',
+    'deps/v8/src/crankshaft/hydrogen.cc',
+    'deps/v8/test/mjsunit/regress/regress-5033.js'
+  ], 'v6.x-staging')
+
+  t.same(labels, ['v8', 'v6.x'])
+
+  t.end()
+})
+
+tap.test('label: no version labels (master)', (t) => {
+  const labels = nodeLabels.resolveLabels([
+    'deps/v8/include/v8-version.h',
+    'deps/v8/src/crankshaft/hydrogen.cc',
+    'deps/v8/test/mjsunit/regress/regress-5033.js'
+  ], 'master')
+
+  t.same(labels, ['v8'])
+
+  t.end()
+})