rules: skip line-length rule for URLs and quoted lines #30
Conversation
lib/rules/line-length.js
Outdated
| var failed = false | ||
| for (let i = 0; i < parsed.body.length; i++) { | ||
| const line = parsed.body[i] | ||
| // Skip quoted lines, e.g. for riginal commit messages of V8 backports. |
There was a problem hiding this comment.
@richardlau thanks, done!
lib/rules/line-length.js
Outdated
| if (line.startsWith(' ')) | ||
| continue | ||
| // Skip lines with URLs. | ||
| if (line.match(/https?:\/\//)) |
There was a problem hiding this comment.
I think RegExp#test would be better here.
There was a problem hiding this comment.
@thefourtheye There’s 0 difference here, right? Anyway, done!
There was a problem hiding this comment.
You are correct, there will be no difference. I was going for idiomatic code 🙂
lib/rules/line-length.js
Outdated
| for (let i = 0; i < parsed.body.length; i++) { | ||
| const line = parsed.body[i] | ||
| // Skip quoted lines, e.g. for original commit messages of V8 backports. | ||
| if (line.startsWith(' ')) |
There was a problem hiding this comment.
Shouldn't this have four space characters? The test actually tests with four space characters.
There was a problem hiding this comment.
I’m not sure … switched to 4 spaces for now, yes
|
@thefourtheye, @joyeecheung, @addaleax I think this can be landed, isn't it? |
|
@lundibundi Yes, I'll push the button |
5 participants
Fixes: #24