Skip to content

jenkins,doc: remove support for building addons with VS2017 #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

jenkins,doc: remove support for building addons with VS2017 #3603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/windows-visualstudio-supported-versions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Supported versions for running the Node.js installer and executable as released.
| v18 | 10 / 2016 |
| v20 | 10 / 2016 |
| v21 | 10 / 2016 |
| v22 | 10 / 2016 |

## For building Node.js Core

Expand All @@ -23,6 +24,7 @@ Supported versions for building Node.js from source.
| v18 | 2019 |
| v20 | 2019 |
| v21 | 2022 |
| v22 | 2022 |

## For building Node.js Addons

Expand All @@ -33,6 +35,7 @@ Supported versions for building Node.js addons. End-users should have one of the
| v18 | 2015, VCBT2015, 2017, 2019 |
| v20 | 2017, 2019 <sup>[1]</sup> |
| v21 | 2017, 2019, 2022 <sup>[1]</sup> |
| v22 | 2019, 2022 <sup>[2]</sup> |

## Official Releases

Expand All @@ -43,8 +46,10 @@ These versions are used to build the official releases.
| v18 | 2012 R2 | 2019 |
| v20 | 2012 R2 | 2019 |
| v21 | 2022 | 2022 |
| v22 | 2022 | 2022 |

## References

1. Support for building addons with Visual Studio 2015 was removed in v19.0.0.
- Pull Request: https://github.com/nodejs/node-gyp/pull/2746
2. Support for building addons with Visual Studio 2017 was removed in v22.0.0.
1 change: 1 addition & 0 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def buildExclusions = [
[ /COMPILED_BY-\w+-arm64$/, testType, lt(20) ], // run tests on arm64 for >=19
// VS versions supported to build add-ons
[ /vs2015-COMPILED_BY/, testType, gte(20) ],
[ /vs2017-COMPILED_BY/, testType, gte(22) ],

// SmartOS -----------------------------------------------
[ /^smartos18/, anyType, gte(16) ],
Expand Down