-
-
Notifications
You must be signed in to change notification settings - Fork 171
Closed
Labels
Description
Refs: nodejs/node#14158
At present our embedding story is very fragile since there is no CI job that asserts that the code can even be compiled at static / dynamic library (let alone validated with the test suite). There are also other build time configurations that aren't continually asserted (esp. --without-intl
and --without-ssl
).
I suggest adding the following (ordered according to my own biased priority):
- add a daily job to just compile with
--shared
on linux + windows + macOS - add a daily job to just compile with
--enable-static
on linux + windows + macOS - add a daily job to build with
--without-ssl
and run tests on full matrix - add a daily job to build with
--without-intl
and run tests on full matrix
P.S. I'd be happy to work on those, but I need access.