Initial support for enveloped signatures #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yaron Naveh » xml-crypto #4 FAILURE |
|
Yaron Naveh » xml-crypto #5 FAILURE |
Contributor
|
Thanks bergie for this important addition! |
LoneRifle
pushed a commit
that referenced
this pull request
Sep 10, 2018
Update Asana/xml-crypto with upstream changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using xml-crypto in the passport-saml library to verify and sign SAML messages. For this, enveloped signatures were necessary, and so this commit adds support for those.
The way enveloped signatures are canonicalized isn't exactly pretty, but at least is a start.
In addition this pull request adds Travis continuous integration support, so every commit to the project gets automatically tested. You need to log into Travis with your GitHub account and enable the repo to get it tested.