fix: update typing for validateScope making scope an optional parameter #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a request is received with no scope in the request body, then the `scope` argument to `validateScope` is undefined instead of an array. This change updates the typings to be consistent with that behaviour.
jorenvandeweyer
approved these changes
Nov 14, 2023
jankapunkt
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a request is received with no scope in the request body, then the
scopeargument tovalidateScopeis undefined instead of an array. This change updates the typings to be consistent with that behaviour.Linked issue(s)
resolves #264
Involved parts of the project
https://github.com/node-oauth/node-oauth2-server/blob/v5.0.0/lib/utils/scope-util.js#L10-L12
Added tests?
n/a
OAuth2 standard
n/a
Reproduction
See issue.