Skip to content

Fix generateAuthorizationCode not being awaited #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jankapunkt merged 2 commits into from
Aug 2, 2023
Merged

Fix generateAuthorizationCode not being awaited #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69cdd2c
Fix generateAuthorizationCode not being awaited
MaximilianGaedig Aug 2, 2023
f198623
Update authorization_code test
MaximilianGaedig Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/handlers/authorize-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ AuthorizeHandler.prototype.handle = async function(request, response) {

const requestedScope = this.getScope(request);
const validScope = await this.validateScope(user, client, requestedScope);
const authorizationCode = this.generateAuthorizationCode(client, user, validScope);
const authorizationCode = await this.generateAuthorizationCode(client, user, validScope);

const ResponseType = this.getResponseType(request);
const codeChallenge = this.getCodeChallenge(request);
Expand Down
7 changes: 4 additions & 3 deletions test/integration/handlers/authorize-handler_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,9 @@ describe('AuthorizeHandler integration', function() {
getClient: function() {
return client;
},
saveAuthorizationCode: function() {
return { authorizationCode: 12345, client: client };
generateAuthorizationCode: async () => 'some-code',
saveAuthorizationCode: async function(code) {
return { authorizationCode: code.authorizationCode, client: client };
}
};
const handler = new AuthorizeHandler({ authorizationCodeLifetime: 120, model: model });
Expand All @@ -586,7 +587,7 @@ describe('AuthorizeHandler integration', function() {
return handler.handle(request, response)
.then(function(data) {
data.should.eql({
authorizationCode: 12345,
authorizationCode: 'some-code',
client: client
});
})
Expand Down