-
Notifications
You must be signed in to change notification settings - Fork 32
fix(blob, file, tests): Minor improvements for Blob and File implementations #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 434
Branches ? 73
========================================
Hits ? 434
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
Ah, same error for blobs and files backed by fs. Maybe you just run tests with |
@jimmywarting @LinusU can somebody review this one, please? |
also could you test |
That's what I do locally :) |
The purpose of this PR is:
This PR includes minor improvements and fixes for File and Blob internals
This is what had to change:
Blob.stream().cancel()
triggersiterator.return()
on underlying source;FilePropertyBag.lastModified
to match browsers behaviour (This behaviour tested in Chrome, Firefox and Safari), now NaN values will be interpreted as0
rather thanDate.now()
;MoveBlob.slice()
implementation outside the Blob class and implement it as generator function. Since blob treats iterable objects as a sequence and behaviour looks the same;This is what like reviewers to know:
This PR is more of a housekeeping with minor changes only. This also changes one thing in terms of File behaviour, just to match File implementations in browsers.
docs:
,fix(area):
,feat(area):
orbreaking(area):