Skip to content

Add more support for i18n #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mythsman opened this issue Jun 27, 2024 · 5 comments
Closed

Add more support for i18n #37

mythsman opened this issue Jun 27, 2024 · 5 comments

Comments

@mythsman
Copy link

It seems that the alert strings in this file (or more) model/src/validator/variable-name-validator.ts have not been converted using context.i18n:

export function variableNameValidator(name: string): string | null {
        if (!name) {
                return 'Variable name is required.';
        }
        if (name.length > MAX_LENGTH) {
                return `Variable name must be ${MAX_LENGTH} characters or less.`;
        }
        if (!/^[A-Za-z][a-zA-Z_0-9-]*$/.test(name)) {
                return 'Variable name contains invalid characters.';
        }
        return null;
}

Could you please provide support for this?

@b4rtaz
Copy link
Contributor

b4rtaz commented Jun 27, 2024

Thanks for reporting, will be fixed soon.

@b4rtaz
Copy link
Contributor

b4rtaz commented Jun 27, 2024

Hello @mythsman, please check the 0.13.1 version.

@mythsman
Copy link
Author

Solved , thanks a lot !

@mythsman mythsman reopened this Jun 28, 2024
@mythsman
Copy link
Author

mythsman commented Jun 28, 2024

And I also find these lines 😏

@b4rtaz
Copy link
Contributor

b4rtaz commented Jun 28, 2024

Oh, you're right. Thanks! Please check the 0.13.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants